Adjust1-102 Delete tagged bail adjustment #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldlharper
reviewed
Feb 9, 2024
server/routes/taggedBailRoutes.ts
Outdated
| const sentencesForCaseSequence = sentencesByCaseSequence.find( | ||
| it => it.caseSequence === adjustment.taggedBail.caseSequence, | ||
| ) | ||
| const sentenceAndOffence = sentencesForCaseSequence.sentences.sort( |
There was a problem hiding this comment.
I think this sort function could be refactored somewhere. It appears a lot through all the tagged bail journeys. (Similar to getActiveSentencesByCaseSequence)
There was a problem hiding this comment.
I've created the method getMostRecentSentenceAndOffence(sentencesAndOffences: PrisonApiOffenderSentenceAndOffences[]) in utils.ts and have replaced all usages of the sort with the call to this new utility method 👍
| public prisonerDetail: PrisonApiPrisoner, | ||
| public adjustment: Adjustment, | ||
| public adjustmentType: AdjustmentType, | ||
| public sentenceAndOffense: PrisonApiOffenderSentenceAndOffences, |
There was a problem hiding this comment.
minor spelling mistake should be sentenceAndOffence
There was a problem hiding this comment.
I have corrected the spelling for this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.