Redefine probation services with model object interface #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sldblog
force-pushed
the
probation-services-to-new-interface
branch
from
d6ab5ff
to
ee1a0f6
Compare
sldblog
commented
Aug 12, 2020
| override fun defineModelEntities(model: Model) { | ||
| system = model.addSoftwareSystem( | ||
| "Workload Management Tool", | ||
| "(WMT) Helps probation practitioners schedule their time based on service user risk" |
There was a problem hiding this comment.
📝 This definition slightly changed to reflect that this tool is only used in the community. As a result, we can use the "probation practitioners" and "service user" terms.
spikeheap
approved these changes
Aug 13, 2020
sldblog
force-pushed
the
probation-services-to-new-interface
branch
from
ee1a0f6
to
8b0f3c1
Compare
|
♻️ rebased after previous merges |
sldblog
force-pushed
the
probation-services-to-new-interface
branch
from
c949546
to
e9b07f8
Compare
This was referenced Aug 13, 2020
|
🎩 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
It mostly moves definitions of systems and relationships out of
defineModelWithDeprecatedSyntaxand into the new(ish) interface kicked off in #15.Please review commit-by-commit (the commit messages include context).
What is the intent behind these changes?
Continuing to remove the old syntax for defining systems.