Add API docs to Delius and NOMIS containers #62
Conversation
sldblog
changed the title
sldblog
changed the title
| @@ -44,6 +44,7 @@ class Delius private constructor() { | |||
| "Community API", | |||
| "API over the nDelius DB used by HMPPS Digital team applications and services", "Java" | |||
| ).apply { | |||
| APIDocs("https://community-api.test.delius.probation.hmpps.dsd.io/swagger-ui.html").addTo(this) | |||
There was a problem hiding this comment.
I notice this is a test URL, where-as the other swagger docs are production.
Also it's not accessible unless on the MoJ VPN - maybe not an issue for a dev, but just an observation about the availability of the swagger docs.
There was a problem hiding this comment.
I'll approve anyway as it is factually correct and what we use right now, but maybe highlights a few inconsistencies we can look at in future.
There was a problem hiding this comment.
👍 Yes, unfortunately, this is the one that's widely shared with everyone at the moment (as far as I can see).
I want to go through the whole lot and settle on pre-production or production URLs at some point next week (coming weeks?). I'll make an issue out of this with a deadline
| @@ -44,6 +44,7 @@ class Delius private constructor() { | |||
| "Community API", | |||
| "API over the nDelius DB used by HMPPS Digital team applications and services", "Java" | |||
| ).apply { | |||
| APIDocs("https://community-api.test.delius.probation.hmpps.dsd.io/swagger-ui.html").addTo(this) | |||
There was a problem hiding this comment.
I'll approve anyway as it is factually correct and what we use right now, but maybe highlights a few inconsistencies we can look at in future.
|
Thank you! 🙇♂️ |
What does this pull request do?
Adds API docs to Delius
community-api(related to ministryofjustice/community-api#242)Adds API docs to NOMIS
prisoner-offender-searchandprison-apis.What is the intent behind these changes?
To make sure we have as many APIs documented and published in #61 as possible.