Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAAR-128: upgrade dependences #23

Merged
merged 3 commits into from
Feb 7, 2022
Merged

HAAR-128: upgrade dependences #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4f42c3
HAAR-128: upgrade dependencies due to npm security audit vulnerability
SimonMitchellMOJ Feb 3, 2022
09e60c4
HAAR-128: upgrade dependencies due to npm security audit vulnerability
SimonMitchellMOJ Feb 3, 2022
416bc2e
HAAR-128: fixes after version bumps
neilmendum Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"@typescript-eslint/no-use-before-define": 0,
"class-methods-use-this": 0,
"no-useless-constructor": 0,
"no-promise-executor-return": 0,
"@typescript-eslint/no-unused-vars": [
1,
{
Expand Down
3 changes: 1 addition & 2 deletions audit-ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"low": true,
"package-manager": "auto",
"registry": "https://registry.npmjs.org",
"allowlist": [1006724]
"registry": "https://registry.npmjs.org"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #12 but can remove now

}
2 changes: 1 addition & 1 deletion integration_tests/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ declare namespace Cypress {
/** * Custom command to signIn. Set failOnStatusCode to false if you expect and non 200 return code
* @example cy.signIn({ failOnStatusCode: boolean })
*/
signIn<S = unknown>(options?: { failOnStatusCode: false }): Chainable<S>
signIn<S = unknown>(options?: { failOnStatusCode: boolean }): Chainable<S>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean we are no longer defaulting to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I changed it because npm typecheck was complaining - I assumed this was being flagged because this PR bumped "typescript": "^4.5.5"

We hadn't provided a type for failOnStatusCode therefore assigning it to false in Cypress config was also flagged by typecheck: Type 'true' is not assignable to type 'false'

And I don't think it's possible to provide a default value because it's a function on an interface

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the template project and it uses 4.5.5 but was able to keep index.d.ts as it was - very odd, maybe they didn't see the warning

}
}