Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating project to use groups in allowlist #39

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Migrating project to use groups in allowlist #39

merged 2 commits into from
Nov 22, 2023

Commits on Nov 13, 2023

  1. Updating generic service version to 2.8

    @andrewrlee
    andrewrlee committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6e6d603 View commit details
    Browse the repository at this point in the history

  2. This PR migrates the project to use groups of IPs in their allowlist. 

    By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses.
If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs.

1 allowlist(s) have been detected that can be migrated.



## Allowlist: helm_deploy/hmpps-authorization/values.yaml

### New Groups

The effect of applying this PR is as follows:

- The following groups will be applied: `internal`
- The size of the allowlist defined in this file will change: `8 => 0 (8 removed)`

### Added IPs

The new Group membership will result in the following IPs being added to your allowlist by applying this PR:

  Merging this PR should not result in any additional IP addresses being added to the allowlist.

### Removed IPs

The following IPs have been identified as unnecessary and will be removed by applying this PR:


- health-kick
    @andrewrlee
    andrewrlee committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c048485 View commit details
    Browse the repository at this point in the history