Haar 1908 audit statements #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new veracode scan for schedueled workflow * Re-add - check_outdated job
…ks (#27) * Updating dependencies and adding slack notifications to outdated checks * Add slack orb
…n established in prison staff hub (#28)
* Ensure that the `SLACK_ACCESS_TOKEN` env var is set for `check_outdated` As the final step (on fail) is a slack notification we need to use a context containing the variable. * Refactor the channel for alerts into parameters This establishes a reusable pattern in case consumers wish to notify slack on other jobs.
The "medium" configuration was not an acceptable term, should be one of "info", "low", "moderate", "high" or "critical". This meant that it would not pick up on anything!
* Updating dependencies and node * Use parameterised slack channel rather than default of typescript alerts channel * Extracting out executor
* WFP-322 use the hmpps/node executor to build * WFP-322 parameterise the node version in the executor * WFP-322 use node version parameter in integration test image * WFP-322 integration tests use new node_redis executor Co-authored-by: Andrew Lee <1517745+andrewrlee@users.noreply.github.com>
* Deploy template project to template k8s namespace
* DT-2404: 💄 Switch to sign in / out instead of login / out * DT-2404: 💄 Don't need .gitignore for husky any more
…ci), and weekly policy scan (upload to veracode portal). (#45)
…imiting at veracode. (#47)
# Conflicts: # server/views/pages/base-clients.njk # server/views/presenters/listBaseClientsPresenter.ts
# Conflicts: # integration_tests/e2e/add-base-client.cy.ts # integration_tests/e2e/edit-base-client-deployment.cy.ts # integration_tests/e2e/edit-base-client-details.cy.ts # integration_tests/pages/addBaseClientDetails.ts # integration_tests/pages/editBaseClientDeploymentDetails.ts # integration_tests/pages/editBaseClientDetails.ts # server/views/pages/edit-base-client-details.njk # server/views/pages/new-base-client-details.njk # server/views/presenters/listBaseClientsPresenter.ts # server/views/presenters/viewBaseClientPresenter.ts
…ents # Conflicts: # package-lock.json # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add audit messaging
This PR also completes tasks ready to sign this app off for QA in dev.
Notes
I have reduced the amount of audit boilerplate code by creating a baseClientAudit function which sets up an audit client at the head of any controller function. This is in the server/audit/baseClientAudit.ts file