Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/filter not working #57

Merged
merged 2 commits into from Jan 18, 2024
Merged

Conversation

thomasridd
Copy link
Contributor

What

Apply filter was currently crashing out to a Service not available screen
This PR fixes that issue and turns the filter functionality into a get request which allows the browser back button to have sensible behaviour and also allows linking

Copy link
Contributor

@SimonMitchellMOJ SimonMitchellMOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonMitchellMOJ SimonMitchellMOJ merged commit 21f668b into main Jan 18, 2024
4 checks passed
@SimonMitchellMOJ SimonMitchellMOJ deleted the bugfix/filter-not-working branch January 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants