[P4-507] Capture PNC number instead of Athena reference #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
force-pushed
the
pnc-number
branch
3 times, most recently
from
0dfdf05
to
a534b75
Compare
This change replaces the capture of the athena reference number with the PNC number as this is going to be more useful to de-dupe Person objects in the future.
This replaces the output of the athena custody reference with the PNC number that we are now capturing.
This extends the person to summary presenter to include output of the Police National Computer number
|
Code Climate has analyzed commit 1e091a1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
slorek
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the capture of the athena reference number
with the PNC number as this is going to be more useful to de-dupe
Person objects in the future.
What it looks like
Move detail page
Create journey