[P4-502] Fix replacing of identifiers #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorek
approved these changes
Jul 24, 2019
This fixes a bug where the identifiers property on a person was being replaced with an empty array if there was already an existing one. This adds a couple of extra tests to ensure this doesn't regress in the future.
teneightfive
force-pushed
the
patch/person-formatting
branch
from
9042b9d
to
2ff2056
Compare
|
Code Climate has analyzed commit 2ff2056 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the identifiers property on a person was
being replaced with an empty array if there was already an existing
one.
This adds a couple of extra tests to ensure this doesn't regress
in the future.