Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4-542] Add created date to CSV download #163

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

teneightfive
Copy link
Contributor

This adds a created at column to the CSV download.

It currently uses updated_at from the API but we can assume
this is the created date because we don't currently support any
update functionality on the frontend.

Have added a todo to ensure this is updated when the API supports
created_at as well as updated_at.

@teneightfive teneightfive self-assigned this Jul 24, 2019
@teneightfive teneightfive changed the title Add created date to CSV download [P4-542] Add created date to CSV download Jul 24, 2019
This adds a created at column to the CSV download.

It currently uses `updated_at` from the API but we can assume
this is the created date because we don't currently support any
update functionality on the frontend.

Have added a todo to ensure this is updated when the API supports
`created_at` as well as `updated_at`.
@codeclimate
Copy link

codeclimate bot commented Jul 24, 2019

Code Climate has analyzed commit 9af6420 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.1% (0.0% change).

View more on Code Climate.

@teneightfive teneightfive merged commit e14d957 into master Jul 25, 2019
@teneightfive teneightfive deleted the created_at-csv branch August 1, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants