[P4-536] Update namespace separator for i18n #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
changed the title
slorek
approved these changes
Jul 25, 2019
teneightfive
commented
Jul 25, 2019
app/move/steps.js
Outdated
| @@ -73,7 +73,7 @@ module.exports = { | |||
| '/health-information': { | |||
| controller: Assessment, | |||
| next: 'save', | |||
| heading: 'moves:steps.health_information.heading', | |||
| heading: 'moves::steps.health_information.heading', | |||
| buttonText: 'actions:schedule_move', | |||
The default namespace separator for the i18n library is currently `:`. This has raised an issue with some strings that don't have translations including a single colon and therefore looking for a particular namespace first. When this is not found it removes that first part of the string and doesn't fallback to the full string. This caused an issue with NOMIS imported ethnicities which included a single colon. This change replaces the single colon with a double with the assumption that this will less likely occur in fallback strings.
teneightfive
force-pushed
the
patch/typeahead
branch
from
1e5519a
to
2e6032b
Compare
|
Code Climate has analyzed commit 2e6032b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default namespace separator for the i18n library is currently
:.This has raised an issue with some strings that don't have translations
including a single colon and therefore looking for a particular
namespace first.
When this is not found it removes that first part of the string
and doesn't fallback to the full string.
This caused an issue with NOMIS imported ethnicities which included
a single colon.
This change replaces the single colon with a double with the
assumption that this will less likely occur in fallback strings.
Note: open to other suggestions regarding alternative namespace
separator