Add page title to form wizard #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
force-pushed
the
form-wizard/page-title
branch
from
e928a4a
to
7d3f14d
Compare
stevehook
reviewed
Jul 29, 2019
app/move/index.js
Outdated
| @@ -13,6 +13,7 @@ const wizardConfig = { | |||
| controller: Form, | |||
| name: 'new-move', | |||
| journeyName: 'new-move', | |||
| journeyPageTitle: 'Create a move', | |||
There was a problem hiding this comment.
not sure how it works but it looks like this needs to be localisable?
There was a problem hiding this comment.
Good spot. Glad you keep remembering this :)
stevehook
approved these changes
Jul 30, 2019
This change sets the page title for form wizard steps. At the moment the form wizard falls back to the default page title. This change adds a new property to the wizard settings to use as the page title. It also renames the `heading` property for each step to be more consistent.
teneightfive
force-pushed
the
form-wizard/page-title
branch
from
7851569
to
afc9cf8
Compare
|
Code Climate has analyzed commit afc9cf8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the page title for form wizard steps. At the moment
the form wizard falls back to the default page title.
This change adds a new property to the wizard settings to use as
the page title. It also renames the
headingproperty for each stepto be more consistent.
Before
After