Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pull Request template #172

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Conversation

teneightfive
Copy link
Contributor

Since the recent analytics changes it's worth us creating a template for new Pull Requests to make sure future changes don't affect anything.

This file can be expanded upon as we think of things that should be considered with new changes.

@teneightfive teneightfive self-assigned this Aug 1, 2019
Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the intent but for some reason GitHub is showing the changes applying to a file called .github/Sheila Sampson 🙀

@teneightfive
Copy link
Contributor Author

What the f! That’s very odd. Haha! I’ll update that!

Since the recent analytics changes it's worth us creating a template for new Pull Requests to make sure future changes don't affect anything.

This file can be expanded upon as we think of things that should be considered with new changes.
@codeclimate
Copy link

codeclimate bot commented Aug 6, 2019

Code Climate has analyzed commit dc7c449 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.1% (0.0% change).

View more on Code Climate.

@teneightfive teneightfive merged commit a6528c4 into master Aug 6, 2019
@teneightfive teneightfive deleted the pull-request-templatet branch August 6, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants