Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4-281] API timeouts #173

Merged
merged 2 commits into from
Aug 6, 2019
Merged

[P4-281] API timeouts #173

merged 2 commits into from
Aug 6, 2019

Conversation

teneightfive
Copy link
Contributor

This change adds middleware to inject a timeout into the axios library
used to make API requests.

Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change needed.

config/index.js Outdated Show resolved Hide resolved
This is a small restructure before adding some further middleware
to the API client.
This adds middleware to inject a timeout into the axios library
used to make API requests.
@codeclimate
Copy link

codeclimate bot commented Aug 6, 2019

Code Climate has analyzed commit 15ed9ed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.2% (0.1% change).

View more on Code Climate.

@teneightfive teneightfive merged commit d2114e7 into master Aug 6, 2019
@teneightfive teneightfive deleted the api-timeouts branch August 6, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants