[P4-317] Store listing state #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
force-pushed
the
store-listing-state
branch
from
f820000
to
9b0ff34
Compare
teneightfive
changed the title
teneightfive
changed the title
teneightfive
force-pushed
the
store-listing-state
branch
2 times, most recently
from
a588c61
to
89bb2de
Compare
slorek
reviewed
Aug 6, 2019
teneightfive
force-pushed
the
store-listing-state
branch
from
89bb2de
to
e2f98da
Compare
slorek
approved these changes
Aug 6, 2019
This change stores the moves filter so that it can be used in other parts of the app to correctly redirect the user.
This uses the stored moves search query to redirect the user back to the correct version of the dashboard they were previously on.
teneightfive
force-pushed
the
store-listing-state
branch
from
e2f98da
to
ab1181f
Compare
|
Code Climate has analyzed commit ab1181f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.2% (0.0% change). View more on Code Climate. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the link back to the dashboard will go back to a non-filtered view.
If a user changes the date and navigates to a move the current date will be lost and they will return to the default dashboard view for "today" on clicking the back to dashboard link.
This change will persist the current filter so that it can be used to go back to the correctly filtered version of the dashboard.