[P4-578] Update GOV.UK Frontend #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
requested review from
stevehook,
Andy-Millar,
slorek and
jason-sims
teneightfive
changed the title
stevehook
approved these changes
Aug 7, 2019
This change includes updating to the latest major version of GOV.UK Frontend which includes a number of breaking changes. The set of changes includes: - Updating file paths, attributes and class names - Migrating to the new accessible focus states - Updating colour references - Updating start buttons
Previously, the GOV.UK Frontend library was not namespaced so if a component with the same name was created within the app it would cause a loading error. Now that the namespace exists we can remove the need to manually handle this within the app itself.
Currently the base template was named `govuk` which is slightly misleading as those templates aren't inheriting the govuk layout, they're actually inheriting the app's base layout. This rename makes that a little clearer.
teneightfive
force-pushed
the
update-govuk-frontend
branch
from
fcfb9fa
to
d9758ab
Compare
|
Code Climate has analyzed commit d9758ab and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes updating to the latest major version (v3.0.0) of
GOV.UK Frontend which includes a number of breaking changes.
The set of changes includes:
Checklist