Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-2095 remove respondent-details.js #2355

Merged
merged 1 commit into from
Mar 15, 2021
Merged

AP-2095 remove respondent-details.js #2355

merged 1 commit into from
Mar 15, 2021

Conversation

RoseSAK
Copy link
Contributor

@RoseSAK RoseSAK commented Mar 8, 2021

What

Link to story

Removed file respondent-details.js.
This file contained code for updated the labels and showing the revealed fields and errors of conditionally revealing radio buttons on the police notified details question.
This is no longer needed as all happens automatically since the page was updated with the new formbuilder.

NOTE:
The label updates in the JS were used in conjunction with the aria-expanded attribute to notify users of conditionally revealed content. The current design system recommendation is not to use the aria-expanded attribute, as it is not an allowed aria-attribute and therefore is often missed by screen readers anyway, and so the new formbuilder does not implement aria-expanded on conditional radio buttons.
Notifying screen readers of revealed content in radio buttons is still an issue which is not fixed in the design system, but there is a planned fix for the end of March 2021: alphagov/govuk-frontend#979

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@RoseSAK RoseSAK added the ready for review Please review label Mar 8, 2021
Copy link
Contributor

@Obsiye Obsiye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoseSAK RoseSAK added approved Approved by code reviewers UAT and removed ready for review Please review labels Mar 8, 2021
@RoseSAK RoseSAK merged commit 12bed5d into master Mar 15, 2021
@colinbruce colinbruce deleted the ap-2095-respondent-js branch May 25, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants