AP 663 Proceed to substantive application #593
Conversation
app/models/bank_holiday.rb
Outdated
|
|
||
| def self.dates | ||
| BankHolidayUpdateWorker.perform_in 10.seconds | ||
| instance = by_updated_at.last || create |
There was a problem hiding this comment.
create! with an exclamation mark?
😃
There was a problem hiding this comment.
Damn! I was so pleased with myself for using save! in the worker. I even did a quick "Check for non-bang save methods before Julien's spots them" check.
| end | ||
|
|
||
| def save | ||
| super && model.provider_used_delegated_functions! |
There was a problem hiding this comment.
I'm a bit uneasy by putting the change of state here because I think that for all the other states it's done in the controller.
So for consistency sake, it would be better to follow the same pattern.
There was a problem hiding this comment.
And it would mean the overloading of save would no longer be necessary. Nice one.
| def dates(group) | ||
| return if data.empty? | ||
|
|
||
| data.dig(group, 'events')&.map { |details| details['date'] } |
There was a problem hiding this comment.
would .pluck('date') work instead of .map { |details| details['date'] } ?
There was a problem hiding this comment.
Yes - it might well do.
reggieb
force-pushed
the
ap-663-proceed-to-substantive-application
branch
from
d0d73c2
to
11c86c8
Compare
reggieb
force-pushed
the
ap-663-proceed-to-substantive-application
branch
from
11c86c8
to
ae130bb
Compare
AP-663
Main change
Adds a page to the providers journey (after
used_delegated_functionsif the provider selects "Yes") that allows the provider to choose between continuing with a substantive application, or returning later.Knock on change
If the provider chooses to return later they are prompted with a date in the future by which they should complete the application. That date is "the current day plus 10 working days". To work that out I needed to:
WorkingDayCalculator). This uses thebusinessgemBankHolidayRetrieverand stored in a modelBankHolidayBankHolidayUpdateWorker) is triggered on callingBankHoliday.datesthat:updated_atof theBankHolidayinstance holding that data.BankHolidayinstance to store the data