Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap-4752: Remove the do you want to use the default level of service or scope for the substantive application? question #6891

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Jul 2, 2024

Do not display the Do you want to use the default level of service or scope for the substantive application? question for SCA applications.

What

Link to story

  • Removed question from substantive_defaults view for SCA proceedings.
  • Updated flow logic so that SCA proceedings should behave as if the user selected Yes to accept the substantive defaults
  • Updated form logic so that SCA proceedings should behave as if the user selected Yes to accept the substantive defaults in terms of updating the default service level and scope limitations.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Do not display the Do you want to use the default level of service or scope for the substantive application?
question for SCA applications.
Skip substantive_level_of_service page for SCA applications
@kmahern kmahern force-pushed the ap-4572-sca-remove-scope-limits-question branch 2 times, most recently from 4dea6ce to 3e391b5 Compare July 3, 2024 09:40
@kmahern kmahern marked this pull request as ready for review July 3, 2024 10:14
@kmahern kmahern requested a review from a team as a code owner July 3, 2024 10:14
@kmahern kmahern added the ready for review Please review label Jul 3, 2024
@kmahern kmahern changed the title ap-4752: Update view to not display question for SCA applications ap-4752: Remove the do you want to use the default level of service or scope for the substantive application? question Jul 3, 2024
@kmahern kmahern removed the ready for review Please review label Jul 3, 2024
Test that the substantive_defaults page redirects correctly when the application is an SCA application
Update substantive_defaults_form to ensure defauults are set for SCA proceedings
@kmahern kmahern force-pushed the ap-4572-sca-remove-scope-limits-question branch from 3e391b5 to faca052 Compare July 3, 2024 10:22
Copy link

sonarcloud bot commented Jul 3, 2024

@kmahern kmahern added the ready for review Please review label Jul 3, 2024
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinbruce colinbruce added approved Approved by code reviewers and removed ready for review Please review labels Jul 3, 2024
@kmahern kmahern added UAT and removed approved Approved by code reviewers labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants