Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5095: Add partner data to reports #6893

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Jul 2, 2024

What

Link to story

This PR adds the following columns to both the overnight digest generation and the Application report

  • has_partner?
  • contrary_interest?
  • partner_dwp_challenge?
  • applicant_age
  • non_means_tested?

As the data is getting more complex, it also adds a link to the reports page to allow a link to confluence to help users interpret the contained within the report

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5095/add-partner-data-to-reports branch 2 times, most recently from 64828bb to ff468ee Compare July 3, 2024 08:41
@colinbruce colinbruce marked this pull request as ready for review July 3, 2024 10:10
@colinbruce colinbruce requested a review from a team as a code owner July 3, 2024 10:10
@colinbruce colinbruce force-pushed the ap-5095/add-partner-data-to-reports branch from 62a8ab2 to 8b836e5 Compare July 3, 2024 10:14
@colinbruce colinbruce added the ready for review Please review label Jul 3, 2024
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinbruce colinbruce force-pushed the ap-5095/add-partner-data-to-reports branch from 8b836e5 to babf996 Compare July 3, 2024 13:09
This links to a Confluence page that will provide guidance on
how to intepret the data on the admin report
@colinbruce colinbruce force-pushed the ap-5095/add-partner-data-to-reports branch from babf996 to e0eaa69 Compare July 3, 2024 13:47
Copy link

sonarcloud bot commented Jul 3, 2024

@colinbruce colinbruce merged commit 7c3e347 into main Jul 4, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5095/add-partner-data-to-reports branch July 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants