Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin/lasb 2942 #49

Merged
merged 29 commits into from
Apr 29, 2024
Merged

Origin/lasb 2942 #49

merged 29 commits into from
Apr 29, 2024

Conversation

Kevin-Paxton
Copy link
Contributor

@Kevin-Paxton Kevin-Paxton commented Apr 24, 2024 •
edited
Loading

What

[Link to story] https://dsdmoj.atlassian.net/jira/software/c/projects/LASB/boards/454?selectedIssue=LASB-2942

Added 98% unit coverage and complete integrations test.

Checklist

Before you ask people to review this PR:

  • Tests should be passing: ./gradlew test
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Kevin-Paxton and others added 25 commits April 22, 2024 15:19
@Kevin-Paxton
Merge pull request #47 from ministryofjustice/main
9a6e317 
Update from main
@Kevin-Paxton
Unit test increas
8d0fb4f
@Kevin-Paxton
Create ServicesConfigurationTest.java
f308058
@Kevin-Paxton
Update EformsAuditTest.java
309f1e9
@Kevin-Paxton
Unit coverage
e36cc4e
@Kevin-Paxton
Create MeansAssessmentTest.java
e6ca6f7
@Kevin-Paxton
Update EformsAuditTest.java
1954276
@Kevin-Paxton
Update MeansAssessmentTest.java
8952578
@Kevin-Paxton
Integration tests
bced14e
@github-actions
Commit changes made by code formatters
e1b0738
@stone-dj
Add OAuth2Response.json
11c60d1
@stone-dj
Merge branch 'origin/LASB-2942' of https://github.com/ministryofjusti…
26ec02b 
…ce/laa-crime-application-tracking-service into origin/LASB-2942
@github-actions
Commit changes made by code formatters
62086a2
@stone-dj
Int test fixes
3b6d09c
@stone-dj
Merge branch 'origin/LASB-2942' of https://github.com/ministryofjusti…
51486f3 
…ce/laa-crime-application-tracking-service into origin/LASB-2942
@stone-dj
Int test fixes
a8a010a
@Kevin-Paxton
Integration test fixes
7b3f5b4
@Kevin-Paxton
Tweaks
d7a5fe3
@Kevin-Paxton
Update EformsAuditTest.java
f9478ee
@Kevin-Paxton
Update .gitignore
b70cd7a
@Kevin-Paxton
Update ServicesConfigurationTest.java
b989a52
@Kevin-Paxton
Update ApplicationTrackingServiceTest.java
fc9f243
@Kevin-Paxton
Update ApplicationTrackingServiceTest.java
b5b27c1
@Kevin-Paxton
Update ApplicationTrackingServiceTest.java
a43f227
@Kevin-Paxton
Update ApplicationTrackingServiceTest.java
b0f0320
@Kevin-Paxton Kevin-Paxton marked this pull request as ready for review April 26, 2024 09:05
@Kevin-Paxton Kevin-Paxton requested a review from a team as a code owner April 26, 2024 09:05
stone-dj
stone-dj requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@stone-dj stone-dj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some feedback

.../test/java/uk/gov/justice/laa/crime/application/tracking/integration/MockWebServerStubs.java Show resolved Hide resolved
.../test/java/uk/gov/justice/laa/crime/application/tracking/integration/MockWebServerStubs.java Outdated Show resolved Hide resolved
...gov/justice/laa/crime/application/tracking/service/ApplicationTrackingServiceCreateTest.java Outdated Show resolved Hide resolved
...k/gov/justice/laa/crime/application/tracking/integration/ApplicationTrackingServiceTest.java Outdated Show resolved Hide resolved
...k/gov/justice/laa/crime/application/tracking/integration/ApplicationTrackingServiceTest.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

stone-dj
stone-dj approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@stone-dj stone-dj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@Kevin-Paxton Kevin-Paxton merged commit 8105303 into main Apr 29, 2024
8 of 11 checks passed
@Kevin-Paxton Kevin-Paxton deleted the origin/LASB-2942 branch April 29, 2024 09:31
@Kevin-Paxton Kevin-Paxton restored the origin/LASB-2942 branch April 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stone-dj stone-dj stone-dj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kevin-Paxton @stone-dj