CRIMAPP-1106 combine partner and client premium bonds #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| list.with_row do |row| | ||
| value = details.premium_bonds_total_value.to_i + details.partner_premium_bonds_total_value.to_i |
There was a problem hiding this comment.
We also need to add this up to pass to MAAT (arguably a problem for their adaptor, but realistically probably just depends who has capacity), if we store the combined amount in the datastore, we can display that here directly
arthurashman
approved these changes
Jun 25, 2024
timpeat
force-pushed
the
CRIMAPP-1106-commbins-premium-bond-totals
branch
from
586f066
to
6d23bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Combines partner an client premium bonds into a single card where appropriate.
Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAPP-1106
Notes for reviewer
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature