add unit tests #470

ASTRobinson · 2024-05-24T15:46:18Z

WIP - add unit-tests

github-actions · 2024-05-24T15:48:44Z

`Trivy Scan` Failed

Show Output

```hcl

Trivy will check the following folders:
test/unit-test

Running Trivy in test/unit-test
2024-05-24T15:48:32Z INFO Need to update DB
2024-05-24T15:48:32Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-24T15:48:34Z INFO Vulnerability scanning is enabled
2024-05-24T15:48:34Z INFO Misconfiguration scanning is enabled
2024-05-24T15:48:34Z INFO Need to update the built-in policies
2024-05-24T15:48:34Z INFO Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-24T15:48:35Z INFO Secret scanning is enabled
2024-05-24T15:48:35Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-24T15:48:35Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-24T15:48:36Z INFO Number of language-specific files num=0
2024-05-24T15:48:36Z INFO Detected config files num=6

../../config.tf (terraform)

Tests: 14 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 14)
Failures: 0 (HIGH: 0, CRITICAL: 0)

../../modules/cloudtrail/main.tf (terraform)

Tests: 5 (SUCCESSES: 4, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (HIGH: 1, CRITICAL: 0)

HIGH: Bucket does not encrypt data with a customer managed key.
════════════════════════════════════════
Encryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys.

See https://avd.aquasec.com/misconfig/avd-aws-0132
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165
via ../../config.tf:103-153 (module.config-bucket)
via main.tf:6-36 (module.baselines)
────────────────────────────────────────
157 ┌ resource "aws_s3_bucket_server_side_encryption_configuration" "default" {
158 │ bucket = aws_s3_bucket.default.id
159 │ rule {
160 │ apply_server_side_encryption_by_default {
161 │ sse_algorithm = var.sse_algorithm
162 │ kms_master_key_id = (var.custom_kms_key != "") ? var.custom_kms_key : ""
163 │ }
164 │ }
165 └ }
────────────────────────────────────────

trivy_exitcode=1

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
test/unit-test

*****************************

Running Checkov in test/unit-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 270, Failed checks: 0, Skipped checks: 51


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
test/unit-test

*****************************

Running tflint in test/unit-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Failed

Show Output

*****************************

Trivy will check the following folders:
test/unit-test

*****************************

Running Trivy in test/unit-test
2024-05-24T15:48:32Z	INFO	Need to update DB
2024-05-24T15:48:32Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-24T15:48:34Z	INFO	Vulnerability scanning is enabled
2024-05-24T15:48:34Z	INFO	Misconfiguration scanning is enabled
2024-05-24T15:48:34Z	INFO	Need to update the built-in policies
2024-05-24T15:48:34Z	INFO	Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-24T15:48:35Z	INFO	Secret scanning is enabled
2024-05-24T15:48:35Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-24T15:48:35Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-24T15:48:36Z	INFO	Number of language-specific files	num=0
2024-05-24T15:48:36Z	INFO	Detected config files	num=6

../../config.tf (terraform)
===========================
Tests: 14 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 14)
Failures: 0 (HIGH: 0, CRITICAL: 0)


../../modules/cloudtrail/main.tf (terraform)
============================================
Tests: 5 (SUCCESSES: 4, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
========================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (HIGH: 1, CRITICAL: 0)

HIGH: Bucket does not encrypt data with a customer managed key.
════════════════════════════════════════
Encryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys.

See https://avd.aquasec.com/misconfig/avd-aws-0132
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165
   via ../../config.tf:103-153 (module.config-bucket)
    via main.tf:6-36 (module.baselines)
────────────────────────────────────────
 157 ┌ resource "aws_s3_bucket_server_side_encryption_configuration" "default" {
 158 │   bucket = aws_s3_bucket.default.id
 159 │   rule {
 160 │     apply_server_side_encryption_by_default {
 161 │       sse_algorithm     = var.sse_algorithm
 162 │       kms_master_key_id = (var.custom_kms_key != "") ? var.custom_kms_key : ""
 163 │     }
 164 │   }
 165 └ }
────────────────────────────────────────


trivy_exitcode=1

github-actions · 2024-06-17T14:50:57Z

`Trivy Scan` Failed

Show Output

```hcl

Trivy will check the following folders:
test/unit-test

Running Trivy in test/unit-test
2024-06-17T14:50:45Z INFO Need to update DB
2024-06-17T14:50:45Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-17T14:50:47Z INFO Vulnerability scanning is enabled
2024-06-17T14:50:47Z INFO Misconfiguration scanning is enabled
2024-06-17T14:50:47Z INFO Need to update the built-in policies
2024-06-17T14:50:47Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-17T14:50:47Z INFO Secret scanning is enabled
2024-06-17T14:50:47Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-17T14:50:47Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-17T14:50:49Z INFO Number of language-specific files num=0
2024-06-17T14:50:49Z INFO Detected config files num=6

../../config.tf (terraform)

Tests: 14 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 14)
Failures: 0 (HIGH: 0, CRITICAL: 0)

../../modules/cloudtrail/main.tf (terraform)

Tests: 5 (SUCCESSES: 4, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (HIGH: 1, CRITICAL: 0)

HIGH: Bucket does not encrypt data with a customer managed key.
════════════════════════════════════════
Encryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys.

See https://avd.aquasec.com/misconfig/avd-aws-0132
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165
via ../../config.tf:103-153 (module.config-bucket)
via main.tf:6-36 (module.baselines)
────────────────────────────────────────
157 ┌ resource "aws_s3_bucket_server_side_encryption_configuration" "default" {
158 │ bucket = aws_s3_bucket.default.id
159 │ rule {
160 │ apply_server_side_encryption_by_default {
161 │ sse_algorithm = var.sse_algorithm
162 │ kms_master_key_id = (var.custom_kms_key != "") ? var.custom_kms_key : ""
163 │ }
164 │ }
165 └ }
────────────────────────────────────────

trivy_exitcode=1

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
test/unit-test

*****************************

Running Checkov in test/unit-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 270, Failed checks: 0, Skipped checks: 51


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
test/unit-test

*****************************

Running tflint in test/unit-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Failed

Show Output

*****************************

Trivy will check the following folders:
test/unit-test

*****************************

Running Trivy in test/unit-test
2024-06-17T14:50:45Z	INFO	Need to update DB
2024-06-17T14:50:45Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-17T14:50:47Z	INFO	Vulnerability scanning is enabled
2024-06-17T14:50:47Z	INFO	Misconfiguration scanning is enabled
2024-06-17T14:50:47Z	INFO	Need to update the built-in policies
2024-06-17T14:50:47Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-17T14:50:47Z	INFO	Secret scanning is enabled
2024-06-17T14:50:47Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-17T14:50:47Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-17T14:50:49Z	INFO	Number of language-specific files	num=0
2024-06-17T14:50:49Z	INFO	Detected config files	num=6

../../config.tf (terraform)
===========================
Tests: 14 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 14)
Failures: 0 (HIGH: 0, CRITICAL: 0)


../../modules/cloudtrail/main.tf (terraform)
============================================
Tests: 5 (SUCCESSES: 4, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
========================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (HIGH: 1, CRITICAL: 0)

HIGH: Bucket does not encrypt data with a customer managed key.
════════════════════════════════════════
Encryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys.

See https://avd.aquasec.com/misconfig/avd-aws-0132
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165
   via ../../config.tf:103-153 (module.config-bucket)
    via main.tf:6-36 (module.baselines)
────────────────────────────────────────
 157 ┌ resource "aws_s3_bucket_server_side_encryption_configuration" "default" {
 158 │   bucket = aws_s3_bucket.default.id
 159 │   rule {
 160 │     apply_server_side_encryption_by_default {
 161 │       sse_algorithm     = var.sse_algorithm
 162 │       kms_master_key_id = (var.custom_kms_key != "") ? var.custom_kms_key : ""
 163 │     }
 164 │   }
 165 └ }
────────────────────────────────────────


trivy_exitcode=1

github-actions · 2024-06-21T11:38:22Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
modules/backup test/backup-test

Running Trivy in modules/backup
2024-06-21T11:38:10Z INFO Need to update DB
2024-06-21T11:38:10Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:38:12Z INFO Vulnerability scanning is enabled
2024-06-21T11:38:12Z INFO Misconfiguration scanning is enabled
2024-06-21T11:38:12Z INFO Need to update the built-in policies
2024-06-21T11:38:12Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:38:12Z INFO Secret scanning is enabled
2024-06-21T11:38:12Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:38:12Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:38:13Z INFO Number of language-specific files num=0
2024-06-21T11:38:13Z INFO Detected config files num=2
trivy_exitcode=0

Running Trivy in test/backup-test
2024-06-21T11:38:13Z INFO Vulnerability scanning is enabled
2024-06-21T11:38:13Z INFO Misconfiguration scanning is enabled
2024-06-21T11:38:13Z INFO Secret scanning is enabled
2024-06-21T11:38:13Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:38:13Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:38:14Z INFO Number of language-specific files num=0
2024-06-21T11:38:14Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/backup test/backup-test

*****************************

Running Checkov in modules/backup
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 1, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

*****************************

Running Checkov in test/backup-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 22, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
modules/backup test/backup-test

*****************************

Running tflint in modules/backup
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in test/backup-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
modules/backup test/backup-test

*****************************

Running Trivy in modules/backup
2024-06-21T11:38:10Z	INFO	Need to update DB
2024-06-21T11:38:10Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:38:12Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:38:12Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:38:12Z	INFO	Need to update the built-in policies
2024-06-21T11:38:12Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:38:12Z	INFO	Secret scanning is enabled
2024-06-21T11:38:12Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:38:12Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:38:13Z	INFO	Number of language-specific files	num=0
2024-06-21T11:38:13Z	INFO	Detected config files	num=2
trivy_exitcode=0

*****************************

Running Trivy in test/backup-test
2024-06-21T11:38:13Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:38:13Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:38:13Z	INFO	Secret scanning is enabled
2024-06-21T11:38:13Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:38:13Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:38:14Z	INFO	Number of language-specific files	num=0
2024-06-21T11:38:14Z	INFO	Detected config files	num=2
trivy_exitcode=0

github-actions · 2024-06-21T11:39:45Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
modules/backup test/backup-test

Running Trivy in modules/backup
2024-06-21T11:39:31Z INFO Need to update DB
2024-06-21T11:39:31Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:39:33Z INFO Vulnerability scanning is enabled
2024-06-21T11:39:33Z INFO Misconfiguration scanning is enabled
2024-06-21T11:39:33Z INFO Need to update the built-in policies
2024-06-21T11:39:33Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:39:33Z INFO Secret scanning is enabled
2024-06-21T11:39:33Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:39:33Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:39:34Z INFO Number of language-specific files num=0
2024-06-21T11:39:34Z INFO Detected config files num=2
trivy_exitcode=0

Running Trivy in test/backup-test
2024-06-21T11:39:34Z INFO Vulnerability scanning is enabled
2024-06-21T11:39:34Z INFO Misconfiguration scanning is enabled
2024-06-21T11:39:34Z INFO Secret scanning is enabled
2024-06-21T11:39:34Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:39:34Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:39:35Z INFO Number of language-specific files num=0
2024-06-21T11:39:35Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/backup test/backup-test

*****************************

Running Checkov in modules/backup
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 1, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

*****************************

Running Checkov in test/backup-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 22, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
modules/backup test/backup-test

*****************************

Running tflint in modules/backup
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in test/backup-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
modules/backup test/backup-test

*****************************

Running Trivy in modules/backup
2024-06-21T11:39:31Z	INFO	Need to update DB
2024-06-21T11:39:31Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:39:33Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:39:33Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:39:33Z	INFO	Need to update the built-in policies
2024-06-21T11:39:33Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:39:33Z	INFO	Secret scanning is enabled
2024-06-21T11:39:33Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:39:33Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:39:34Z	INFO	Number of language-specific files	num=0
2024-06-21T11:39:34Z	INFO	Detected config files	num=2
trivy_exitcode=0

*****************************

Running Trivy in test/backup-test
2024-06-21T11:39:34Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:39:34Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:39:34Z	INFO	Secret scanning is enabled
2024-06-21T11:39:34Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:39:34Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:39:35Z	INFO	Number of language-specific files	num=0
2024-06-21T11:39:35Z	INFO	Detected config files	num=2
trivy_exitcode=0

github-actions · 2024-06-21T11:49:53Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
modules/backup test/backup-test

Running Trivy in modules/backup
2024-06-21T11:49:42Z INFO Need to update DB
2024-06-21T11:49:42Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:49:44Z INFO Vulnerability scanning is enabled
2024-06-21T11:49:44Z INFO Misconfiguration scanning is enabled
2024-06-21T11:49:44Z INFO Need to update the built-in policies
2024-06-21T11:49:44Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:49:44Z INFO Secret scanning is enabled
2024-06-21T11:49:44Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:49:44Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:49:45Z INFO Number of language-specific files num=0
2024-06-21T11:49:45Z INFO Detected config files num=2
trivy_exitcode=0

Running Trivy in test/backup-test
2024-06-21T11:49:45Z INFO Vulnerability scanning is enabled
2024-06-21T11:49:45Z INFO Misconfiguration scanning is enabled
2024-06-21T11:49:45Z INFO Secret scanning is enabled
2024-06-21T11:49:45Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:49:45Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:49:45Z INFO Number of language-specific files num=0
2024-06-21T11:49:45Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/backup test/backup-test

*****************************

Running Checkov in modules/backup
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 1, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

*****************************

Running Checkov in test/backup-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 22, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
modules/backup test/backup-test

*****************************

Running tflint in modules/backup
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in test/backup-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
modules/backup test/backup-test

*****************************

Running Trivy in modules/backup
2024-06-21T11:49:42Z	INFO	Need to update DB
2024-06-21T11:49:42Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:49:44Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:49:44Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:49:44Z	INFO	Need to update the built-in policies
2024-06-21T11:49:44Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:49:44Z	INFO	Secret scanning is enabled
2024-06-21T11:49:44Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:49:44Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:49:45Z	INFO	Number of language-specific files	num=0
2024-06-21T11:49:45Z	INFO	Detected config files	num=2
trivy_exitcode=0

*****************************

Running Trivy in test/backup-test
2024-06-21T11:49:45Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:49:45Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:49:45Z	INFO	Secret scanning is enabled
2024-06-21T11:49:45Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:49:45Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:49:45Z	INFO	Number of language-specific files	num=0
2024-06-21T11:49:45Z	INFO	Detected config files	num=2
trivy_exitcode=0

github-actions · 2024-06-21T11:52:38Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
modules/backup test/backup-test

Running Trivy in modules/backup
2024-06-21T11:52:24Z INFO Need to update DB
2024-06-21T11:52:24Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:52:26Z INFO Vulnerability scanning is enabled
2024-06-21T11:52:26Z INFO Misconfiguration scanning is enabled
2024-06-21T11:52:26Z INFO Need to update the built-in policies
2024-06-21T11:52:26Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:52:26Z INFO Secret scanning is enabled
2024-06-21T11:52:26Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:52:26Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:52:27Z INFO Number of language-specific files num=0
2024-06-21T11:52:27Z INFO Detected config files num=2
trivy_exitcode=0

Running Trivy in test/backup-test
2024-06-21T11:52:27Z INFO Vulnerability scanning is enabled
2024-06-21T11:52:27Z INFO Misconfiguration scanning is enabled
2024-06-21T11:52:27Z INFO Secret scanning is enabled
2024-06-21T11:52:27Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:52:27Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:52:28Z INFO Number of language-specific files num=0
2024-06-21T11:52:28Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/backup test/backup-test

*****************************

Running Checkov in modules/backup
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 1, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

*****************************

Running Checkov in test/backup-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 22, Failed checks: 0, Skipped checks: 1


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
modules/backup test/backup-test

*****************************

Running tflint in modules/backup
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in test/backup-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
modules/backup test/backup-test

*****************************

Running Trivy in modules/backup
2024-06-21T11:52:24Z	INFO	Need to update DB
2024-06-21T11:52:24Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T11:52:26Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:52:26Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:52:26Z	INFO	Need to update the built-in policies
2024-06-21T11:52:26Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T11:52:26Z	INFO	Secret scanning is enabled
2024-06-21T11:52:26Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:52:26Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:52:27Z	INFO	Number of language-specific files	num=0
2024-06-21T11:52:27Z	INFO	Detected config files	num=2
trivy_exitcode=0

*****************************

Running Trivy in test/backup-test
2024-06-21T11:52:27Z	INFO	Vulnerability scanning is enabled
2024-06-21T11:52:27Z	INFO	Misconfiguration scanning is enabled
2024-06-21T11:52:27Z	INFO	Secret scanning is enabled
2024-06-21T11:52:27Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T11:52:27Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T11:52:28Z	INFO	Number of language-specific files	num=0
2024-06-21T11:52:28Z	INFO	Detected config files	num=2
trivy_exitcode=0

richgreen-moj · 2024-06-21T12:00:37Z

Closing as I'm raising a new PR based on this branch.

ASTRobinson and others added 2 commits May 24, 2024 16:45

add unit tests

f10fd31

Commit changes made by code formatters

e833708

ASTRobinson mentioned this pull request May 24, 2024

🧪 Add unit tests where missing ministryofjustice/modernisation-platform#6490

Open

14 tasks

merging in latest changes from main

4d1205a

richgreen-moj added 2 commits June 21, 2024 12:36

add backup module tests

fc86b92

fix branch name

9f968cc

fix formatting

5990cce

update go version 1.18

a85659e

richgreen-moj closed this Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add unit tests #470

add unit tests #470

ASTRobinson commented May 24, 2024

github-actions bot commented May 24, 2024

../../config.tf (terraform)

../../modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github-actions bot commented Jun 17, 2024

../../config.tf (terraform)

../../modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024

richgreen-moj commented Jun 21, 2024

add unit tests #470

add unit tests #470

Conversation

ASTRobinson commented May 24, 2024

github-actions bot commented May 24, 2024

Trivy Scan Failed

../../config.tf (terraform)

../../modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

CTFLint Scan Success

Trivy Scan Failed

github-actions bot commented Jun 17, 2024

Trivy Scan Failed

../../config.tf (terraform)

../../modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

CTFLint Scan Success

Trivy Scan Failed

github-actions bot commented Jun 21, 2024

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

github-actions bot commented Jun 21, 2024

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

github-actions bot commented Jun 21, 2024

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

github-actions bot commented Jun 21, 2024

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

richgreen-moj commented Jun 21, 2024

`Trivy Scan` Failed

`CTFLint Scan` Success

`Trivy Scan` Failed

`Trivy Scan` Failed

`CTFLint Scan` Success

`Trivy Scan` Failed

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success