re-introduce security scanning in repos #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB. This PR should solve issue #2822 |
|
|
For public repositories this setting is always set and can't be applied, so making the block conditional and only there for non public repos. https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository#advanced_security
davidkelliott
approved these changes
Jun 22, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed security scanning inhttps://github.com//pull/2795
From reading the linked issue, this was resolved in integrations/terraform-provider-github#1489
This PR removes the version pin and allows us to stay up-to-date without relying on dependabot PRs, as well as reintroducing the
security_and_analysisblock in our code.edit: update -
For public repositories the advanced security setting is always set and can't be applied,
so making the block conditional and only there for non public repos.
https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository#advanced_security