Skip to content

Commit

Permalink
Tweaks to get linting working (#63)
Browse files Browse the repository at this point in the history
* Additional tweaks to fix deployment

* Fix internal linking

* Enable check-internal-hash

* Tweaks
  • Loading branch information
zheileman committed Feb 7, 2024
1 parent fb537d4 commit 6809e7a
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/check-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ name: Check for broken links

on:
workflow_dispatch:
pull_request:
paths:
- "source/**"
# push:
# branches:
# - "more-updates"
# pull_request:
# paths:
# - "source/**"

jobs:
check_links:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,4 @@ jobs:
cd github-pages
tar -xvf artifact.tar
npm install linkinator
npx linkinator . --recurse --markdown \
# --skip https://github.com/ministryofjustice/some-private-repo \
npx linkinator . --recurse --markdown --skip '\-deploy$'
2 changes: 1 addition & 1 deletion config/tech-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ host: https://ministryofjustice.github.io/moj-forms-tech-docs
# Header-related options
show_govuk_logo: true
service_name: MOJ Forms Tech Docs
service_link: /moj-forms-tech-docs
service_link: '#moj-forms-tech-docs'

# Links to show on right-hand-side of header
header_links:
Expand Down
4 changes: 2 additions & 2 deletions makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
IMAGE := ministryofjustice/tech-docs-github-pages-publisher:1.3
IMAGE := ministryofjustice/tech-docs-github-pages-publisher:v3.0.2

# Use this to run a local instance of the documentation site, while editing
.PHONY: preview
Expand All @@ -7,4 +7,4 @@ preview:
-v $$(pwd)/config:/app/config \
-v $$(pwd)/source:/app/source \
-p 4567:4567 \
-it $(IMAGE) /publishing-scripts/preview.sh
-it $(IMAGE) /scripts/preview.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ We need to record the architectural decisions made on this project.

## Decision

We will use Architecture Decision Records, as [described by Michael Nygard](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions).
We will use Architecture Decision Records, as [described by Michael Nygard](https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions).

## Consequences

Expand Down

0 comments on commit 6809e7a

Please sign in to comment.