Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fix checkboxes vanishing #113

Merged
merged 1 commit into from
Jan 23, 2024
Merged

🪲 fix checkboxes vanishing #113

merged 1 commit into from
Jan 23, 2024

Conversation

tamsinforbes
Copy link
Contributor

👀 Purpose

  • Fix the logic so that the correct checkboxes still show after a reminder to select at least one org.

♻️ What's changed

  • Moved checkbox creation to above conditional so it is accessible after the error message also.

📝 Notes

@tamsinforbes tamsinforbes marked this pull request as ready for review January 23, 2024 15:48
Copy link
Contributor

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 1 0 0.73s
✅ PYTHON flake8 1 0 0.42s
✅ PYTHON isort 1 1 0 0.2s
✅ PYTHON pylint 1 0 4.59s
✅ REPOSITORY gitleaks yes no 0.44s
❌ REPOSITORY trivy yes 1 5.79s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@tamsinforbes tamsinforbes merged commit 0bf8e0a into main Jan 23, 2024
3 of 4 checks passed
@tamsinforbes tamsinforbes deleted the fix-checkbox-vanish-bug branch January 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants