Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate organisation selection against valid options #150

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

levgorbunov1
Copy link
Contributor

  • Validates user selection for organisations against valid options set in configuration.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 2 0 0.85s
❌ PYTHON flake8 2 6 0.46s
✅ PYTHON isort 2 2 0 0.17s
❌ PYTHON pylint 2 3 4.94s
✅ REPOSITORY gitleaks yes no 0.46s
✅ REPOSITORY trivy yes no 5.21s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

connormaglynn
connormaglynn previously approved these changes Feb 5, 2024
Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth doing the same validation in the github_service class as an extra measure to ensure that the value are valid before actually using them to send the invitation 📬

Happy for that to be a separate PR though 😁

tamsinforbes
tamsinforbes previously approved these changes Feb 6, 2024
Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝🌖🚀LGTM🚀🌘🌚

Minor comment to update the logging wording to match the changes in my commit.

join_github_app/main/services/github_service.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝🌖🚀LGTM🚀🌘🌚

@levgorbunov1 levgorbunov1 merged commit 6f2bfdf into main Feb 6, 2024
3 of 4 checks passed
@levgorbunov1 levgorbunov1 deleted the validate-org-selection branch February 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants