-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate organisation selection against valid options #150
Conversation
levgorbunov1
commented
Feb 5, 2024
- Validates user selection for organisations against valid options set in configuration.
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also worth doing the same validation in the github_service
class as an extra measure to ensure that the value are valid before actually using them to send the invitation 📬
Happy for that to be a separate PR though 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌝🌖🚀LGTM🚀🌘🌚
Minor comment to update the logging wording to match the changes in my commit.
Co-authored-by: tam <32667518+tamsinforbes@users.noreply.github.com>
516c537
to
df18093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌝🌖🚀LGTM🚀🌘🌚