Fix for luhn not generating correct check digit

ministryofjustice · Jun 18, 2014 · 22256d8 · 22256d8
1 parent dc29e80
commit 22256d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Opg/Common/Model/Entity/LuhnCheckDigit.php b/src/Opg/Common/Model/Entity/LuhnCheckDigit.php
@@ -19,7 +19,7 @@ public static function createCheckSum($number)
        $checksum = 0;
 
         foreach (str_split(strrev((string) $number)) as $i => $d) {
-            $checksum += ($i%2 === 0) ? $d * 2 : $d;
+            $checksum += ($i%2 === 0) ? array_sum(str_split($d * 2)) : $d;
         }
 
         $checksum *= 9;

diff --git a/tests/OpgTest/Common/Model/Entity/LuhnCheckDigitTest.php b/tests/OpgTest/Common/Model/Entity/LuhnCheckDigitTest.php
@@ -15,7 +15,7 @@ public function testCreateEvenNumbers()
 
     public function testCreateOddNumbers()
     {
-        $expected = 6;
+        $expected = 5;
         $this->assertEquals($expected, LuhnCheckDigit::createCheckSum(12345));
     }