[#APOLLO-3238] Improve CaseItem->BusinessRule test

ministryofjustice · Jun 19, 2014 · 9b28c88 · 9b28c88
1 parent f6eb47d
commit 9b28c88
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/Opg/Core/Model/Entity/CaseItem/CaseItem.php b/src/Opg/Core/Model/Entity/CaseItem/CaseItem.php
@@ -829,7 +829,7 @@ public function setBusinessRules(ArrayCollection $businessRules)
      *
      * @return CaseItem
      */
-    public function addBusinessRules(BusinessRule $businessRule)
+    public function addBusinessRule(BusinessRule $businessRule)
     {
         $this->businessRules[] = $businessRule;
 

diff --git a/tests/OpgTest/Core/Model/Entity/CaseItem/CaseItemTest.php b/tests/OpgTest/Core/Model/Entity/CaseItem/CaseItemTest.php
@@ -471,41 +471,45 @@ public function testSetGetBusinessRules()
 
     public function testAddGetBusinessRules()
     {
+        $mock = $this->getMockedClass();
+
         $businessRule = new BusinessRule();
         $businessRule->setKey('testkey');
         $businessRule->setValue('testvalue');
 
         $collection = new ArrayCollection();
         $collection->add($businessRule);
 
-        $this->getMockedClass()->addBusinessRule($businessRule);
+        $mock->addBusinessRule($businessRule);
 
-        $this->assertEquals($collection, $this->getMockedClass()->getBusinessRules());
+        $this->assertEquals($collection, $mock->getBusinessRules());
     }
 
     public function testGetBusinessRule()
     {
         $key = 'testkey';
+        $mock = $this->getMockedClass();
 
         $businessRule = new BusinessRule();
         $businessRule->setKey($key);
         $businessRule->setValue('testvalue');
 
-        $this->getMockedClass()->addBusinessRule($businessRule);
+        $mock->addBusinessRule($businessRule);
 
-        $this->assertEquals($businessRule, $this->getMockedClass()->getBusinessRule($key));
+        $this->assertEquals($businessRule, $mock->getBusinessRule($key));
     }
 
     public function testGetBusinessRuleNotFound()
     {
         $key = 'testkey';
+        $mock = $this->getMockedClass();
 
         $businessRule = new BusinessRule();
         $businessRule->setKey($key);
         $businessRule->setValue('testvalue');
 
-        $this->getMockedClass()->addBusinessRule($businessRule);
+        $mock->addBusinessRule($businessRule);
 
-        $this->assertEquals(null, $this->getMockedClass()->getBusinessRule($key . '2'));
+        $this->assertEquals(null, $mock->getBusinessRule($key . '2'));
     }
 }