This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Added getDisplayName to Person entity #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->assertEquals($expectedFirst, $this->person->getFirstname()); | ||
| $this->assertEquals($expectedMiddle, $this->person->getMiddlename()); | ||
| $this->assertEquals($expectedSurname, $this->person->getSurname()); | ||
| $this->assertEquals($expectedOtherNames, $this->person->getOtherNames()); | ||
| $this->assertEquals($expectedDisplay, $this->person->getDisplayName()); |
There was a problem hiding this comment.
This might be a bit picky and not worth it, but should we be testing cases where there is no title, firstname and/or surname? e.g. Mr Saunders. (no firstname)
There was a problem hiding this comment.
Further unit test added
|
Unit tests pass |
|
Unit tests pass |
rs-saunders
added a commit
that referenced
this pull request
Apr 24, 2015
…_Name_To_Title_Of_Each_Outbound_Letter Added getDisplayName to Person entity
rs-saunders
deleted the
SDV-1136_Add_Recipient_Name_To_Title_Of_Each_Outbound_Letter
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.