Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resequence and rename to match updated prototype flow #76

Merged
merged 1 commit into from Sep 6, 2022
Merged

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Sep 6, 2022

because I had been following the prototype as it was...

@hawx hawx self-assigned this Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 93.50% // Head: 93.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d342755) compared to base (7c4f0ae).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   93.50%   93.49%   -0.01%     
==========================================
  Files          22       22              
  Lines         877      876       -1     
==========================================
- Hits          820      819       -1     
  Misses         42       42              
  Partials       15       15              
Flag Coverage Δ
unittests 93.49% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/internal/page/data.go 100.00% <ø> (ø)
app/internal/page/your_details.go 92.85% <78.94%> (ø)
app/internal/page/app.go 100.00% <100.00%> (ø)
app/internal/page/auth_redirect.go 87.50% <100.00%> (ø)
app/internal/page/lpa_type.go 100.00% <100.00%> (ø)
app/internal/page/task_list.go 100.00% <100.00%> (ø)
app/internal/page/who_is_the_lpa_for.go 100.00% <100.00%> (ø)
app/internal/page/your_address.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hawx hawx merged commit a13590a into main Sep 6, 2022
@hawx hawx deleted the prototype-flow branch September 6, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants