Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2117 - Update documentation #396

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented May 16, 2024

Purpose

Provide examples of how to use image and zip artifacts.

Fixes: MLPAB-2117

Approach

  • fix pre-release mode for releases
  • add info to the readme
  • add examples to docs

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (9da6046) to head (d63bcbe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files           4        4           
  Lines         185      185           
=======================================
  Hits          101      101           
  Misses         72       72           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review May 16, 2024 09:53
@andrewpearce-digital andrewpearce-digital requested review from a team as code owners May 16, 2024 09:53
docs/examples.md Outdated

## Fetching a version tag of the Lambda Function Zip and Lambda Layer Package

The workflow for this repositry writes a version tag to the SSM Parameter Store. This can be used to fetch the version of the Lambda Function Zip and Lambda Layer Package. The parameter is in the management account in the eu-west-1 region.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

jamesrwarren
jamesrwarren previously approved these changes May 16, 2024
jamesrwarren
jamesrwarren previously approved these changes May 16, 2024
@andrewpearce-digital andrewpearce-digital merged commit 0a67c00 into main May 16, 2024
13 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2117-update-documentation-on-how-to-use-the-zips-and-images branch May 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants