Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit email addresses #305

Merged

Conversation

gregtyler
Copy link
Contributor

Make field editable and sent it to the API

For VEGA-1405 #minor

@github-actions
Copy link

github-actions bot commented Aug 10, 2022

Unit Test Results

276 tests  ±0   276 ✔️ ±0   1m 40s ⏱️ -17s
    3 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 7375a67. ± Comparison against base commit 3d28fea.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #305 (7375a67) into main (3d28fea) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   84.99%   85.00%   +0.01%     
==========================================
  Files          42       42              
  Lines        1206     1207       +1     
==========================================
+ Hits         1025     1026       +1     
  Misses        120      120              
  Partials       61       61              
Impacted Files Coverage Δ
internal/server/edit_user.go 91.11% <100.00%> (ø)
internal/sirius/edit_user.go 80.00% <100.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

GemTay
GemTay previously approved these changes Aug 11, 2022
@gregtyler gregtyler force-pushed the VEGA-1405-allow-system-admins-to-edit-users-account-email branch from 8ae3ca1 to 5a2b634 Compare August 11, 2022 08:43
Make field editable and sent it to the API

For VEGA-1405 #minor
@gregtyler gregtyler force-pushed the VEGA-1405-allow-system-admins-to-edit-users-account-email branch from 5a2b634 to 7375a67 Compare August 11, 2022 10:39
@gregtyler gregtyler merged commit 0ae5866 into main Aug 11, 2022
@gregtyler gregtyler deleted the VEGA-1405-allow-system-admins-to-edit-users-account-email branch August 11, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants