Bulk move people from an old to a new team for specific teams #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertism
reviewed
Nov 2, 2022
| if old_team && new_team | ||
| puts "Copying #{old_team.people.count} members" | ||
| new_team.people << old_team.people | ||
| old_team.people.delete_all |
There was a problem hiding this comment.
I presume you've tested this, but just wanted to make sure that doing new_team.people << old_team.people means you end up with 2 sets of people, so it is then safe to delete them from old_team.
There was a problem hiding this comment.
Sorry, missed this! Yep, exactly so, I've just been testing it again locally as a sanity check.
The many-to-many table memberships is what's getting modified here so for example
Membership Destroy (43.9ms) DELETE FROM "memberships" WHERE "memberships"."id" IN (SELECT "memberships"."id" FROM "memberships" LEFT OUTER JOIN "people" ON "people"."id" = "memberships"."person_id" WHERE "memberships"."group_id" = $1 AND "memberships"."person_id" IN ($2, $3, $4, $5, $6, $7, $8, $9, $10) ORDER BY people.surname) [["group_id", 18], ["person_id", 74], ["person_id", 73], ["person_id", 61], ["person_id", 50], ["person_id", 62], ["person_id", 72], ["person_id", 60], ["person_id", 48], ["person_id", 49]]
=> 9
vertism
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support some cleaning up work that's been done to tidy up members under some specific prison establishments
The user has set up old and new teams as described in the ticket.
Verify the team names are as they should be, then run
rake peoplefinder:data:etc:bulk_move_lewes_huntercombe_coldingleyto move all team members from the old team into the new team, preserving existing members of the new team, and delete the old team.The script uses
<<to copy the members from the old team and preserve existing memberships in the new team.The old teams have no sub teams.
Self-review checklist
CT-7654 ...Screenshots
Related JIRA tickets
Deployment
Manual testing instructions
To replicate the scenario, find three teams that have members in them. Create three new empty teams and add a couple of canary users to one of them matching the scenarios below. Log into the namespace and run the rake task. You get one go and there's no rollback, so recommend testing thoroughly on non-prod environments first.
Scenarios to test