Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIC-2409 dev preprod bug #116

Merged
merged 5 commits into from Sep 5, 2022
Merged

PIC-2409 dev preprod bug #116

merged 5 commits into from Sep 5, 2022

Conversation

theDustRoom
Copy link
Member

@theDustRoom theDustRoom commented Sep 5, 2022

Changed Community API URL after a conversation with Matt Ryall
Also made changes as NDelius makes more sense to pass eventNumber instead of entityId.
Also enforces String as NDelius was passing an Integer but a String is used later.

Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk>
Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk>
Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk>
Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk>
Copy link
Contributor

@jhevans jhevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@theDustRoom theDustRoom merged commit a177515 into main Sep 5, 2022
@theDustRoom theDustRoom deleted the PIC-2409-dev-preprod-bug branch September 5, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants