Don't install development and test gems in production #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitBarnard
approved these changes
Aug 19, 2020
jivdhaliwal
reviewed
Aug 19, 2020
| RUN bundle config set no-cache 'true' && \ | ||
| bundle install ${BUNDLE_INSTALL_FLAGS} | ||
| bundle install |
There was a problem hiding this comment.
How come we're removing this here? We set it in docker-compose to speed up the installation by running it in parallel using the jobs flag (BUNDLE_INSTALL_FLAGS: "${BUNDLE_INSTALL_FLAGS:- --jobs 20 --retry 5}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler has deprecated the "--without flag":
rubygems/bundler#7531
By setting BUNDLE_WITHOUT env variable you can achieve the same thing.
Docker images should be smaller with less dependencies.