-
Notifications
You must be signed in to change notification settings - Fork 550
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
+ Add metadata lazy accessor to Runnable / Result. (matteeyah)
[git-p4: depot-paths = "//src/minitest/dev/": change = 13875]
- Loading branch information
Showing
2 changed files
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de80282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the end of the world, but it's not uncommon for test classes to have some private accessors as shortcuts, and
metadata
is a fairly common name.This hard broke a few tests in our app.
de80282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke a few tests at GitHub as well (we Marshal.dump the result when running tests in parallel, and ended up with some objects in the metadata that are not dumpable).