Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty backtrace from external filter #696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle empty backtrace from external filter #696

wants to merge 1 commit into from

Commits on May 19, 2017

  1. Handle empty backtrace from external filter 

    In the wild the backtrace_filter can be set by external filter (Rails do
it for their silencer). This can lead to the case there the external
backtrace_filer returns empty array. Other parts of minitest count on
the fact that there will still be something in the backtrace to use, and
can lead to issues such as "undefined method `split' for nil:NilClass"
when producing deprecation warnings.

Since we already had the logic to use all the backtrace when filtering
too much, I've moved this logic to be used also for external filters.
    @iNecas
    iNecas committed May 19, 2017
    Configuration menu
    Copy the full SHA
    89c6f0e View commit details
    Browse the repository at this point in the history