Support the new message format of NameError in Ruby 3.3 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change accepts the following change of the message of NameError in a test. ``` old: undefined method `write' for nil:NilClass new: undefined method `write' for nil ```
|
Done! Thank you... I'll get a release out shortly. |
mame
added a commit
to mame/ruby
that referenced
this pull request
Feb 10, 2023
... to support the new error message. minitest/minitest#942 ruby/debug#889
mame
added a commit
to mame/ruby
that referenced
this pull request
Feb 10, 2023
... to support the new error message. minitest/minitest#942 ruby/debug#889
mame
added a commit
to mame/ruby
that referenced
this pull request
Feb 18, 2023
... to support the new error message. minitest/minitest#942 ruby/debug#889
mame
added a commit
to mame/ruby
that referenced
this pull request
Feb 19, 2023
This is a preparation for a new message format of NameError. [Feature #18285] minitest/minitest#942 ruby/debug#889
mame
added a commit
to ruby/ruby
that referenced
this pull request
Feb 19, 2023
This is a preparation for a new message format of NameError. [Feature #18285] minitest/minitest#942 ruby/debug#889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running a trial in Ruby dev branch to change the message format of NameError.
https://bugs.ruby-lang.org/issues/18285
Unfortunately, this change makes a test of minitest fail. Because minitest is bundled with Ruby and tested in
make test-bundled-gems, I would appreciate it if you could accept the new format in the side of minitest.Specifically, the following change matters in the test of minitest.
Thanks,