Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set minimum required CMake to 3.5 #43

Merged
merged 1 commit into from Jan 16, 2024

Conversation

fanquake
Copy link

@fanquake fanquake commented Jan 12, 2024

Avoids:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

@miniupnp
Copy link
Owner

https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

Changed in version 3.27: Compatibility with versions of CMake older than 3.5 is deprecated. Calls to cmake_minimum_required(VERSION) or cmake_policy(VERSION) that do not specify at least 3.5 as their policy version (optionally via ...) will produce a deprecation warning in CMake 3.27 and above.

Changed in version 3.19: Compatibility with versions of CMake older than 2.8.12 is deprecated. Calls to cmake_minimum_required(VERSION) or cmake_policy(VERSION) that do not specify at least 2.8.12 as their policy version (optionally via ...) will produce a deprecation warning in CMake 3.19 and above.

So I think we should use cmake_minimum_required(VERSION 3.5)

@miniupnp miniupnp self-assigned this Jan 15, 2024
Avoids:
```bash
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
```
@fanquake
Copy link
Author

So I think we should use cmake_minimum_required(VERSION 3.5)

Sure. Changed to 3.5.

@fanquake fanquake changed the title build: set minimum required CMake to 3.12 build: set minimum required CMake to 3.5 Jan 15, 2024
@miniupnp miniupnp merged commit f2433be into miniupnp:master Jan 16, 2024
@fanquake fanquake deleted the update_cmake_minimum branch January 17, 2024 10:31
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 22, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 22, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 25, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 26, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 26, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 5, 2024
This includes once CMake related change I upstreamed:
miniupnp/libnatpmp#43.
fanquake added a commit to bitcoin/bitcoin that referenced this pull request Apr 25, 2024
3c1ae3e depends: switch libnatpmp to CMake (Cory Fields)
72ba7b5 depends: libnatpmp f2433bec24ca3d3f22a8a7840728a3ac177f94ba (fanquake)

Pull request description:

  This picks up one of the changes from #29232, which is a switch to building libnatpmp with CMake. It includes an update to the most recent version of libnatpmp (miniupnp/libnatpmp@f2433be), which includes (miniupnp/libnatpmp#43).

  From an initial look I couldn't find any significant difference between the Autotools and CMake produced libs.

ACKs for top commit:
  m3dwards:
    ACK 3c1ae3e
  hebasto:
    ACK 3c1ae3e.
  TheCharlatan:
    ACK 3c1ae3e

Tree-SHA512: 1dd9d9933a5fceb9f8c4e1d68cd5cb4456a10a6dd27a6f6316f14493f9d2efad981ef8be9570c09ca82d45163aebd7f4cb2b2449989ec6084268ddba9a564c83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants