New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set minimum required CMake to 3.5 #43
Conversation
https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
So I think we should use |
Avoids: ```bash CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake. Update the VERSION argument <min> value or use a ...<max> suffix to tell CMake that the project does not need compatibility with older versions. ```
d6a5791
to
2c1dde7
Compare
Sure. Changed to 3.5. |
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
This includes once CMake related change I upstreamed: miniupnp/libnatpmp#43.
3c1ae3e depends: switch libnatpmp to CMake (Cory Fields) 72ba7b5 depends: libnatpmp f2433bec24ca3d3f22a8a7840728a3ac177f94ba (fanquake) Pull request description: This picks up one of the changes from #29232, which is a switch to building libnatpmp with CMake. It includes an update to the most recent version of libnatpmp (miniupnp/libnatpmp@f2433be), which includes (miniupnp/libnatpmp#43). From an initial look I couldn't find any significant difference between the Autotools and CMake produced libs. ACKs for top commit: m3dwards: ACK 3c1ae3e hebasto: ACK 3c1ae3e. TheCharlatan: ACK 3c1ae3e Tree-SHA512: 1dd9d9933a5fceb9f8c4e1d68cd5cb4456a10a6dd27a6f6316f14493f9d2efad981ef8be9570c09ca82d45163aebd7f4cb2b2449989ec6084268ddba9a564c83
Avoids: