Linux build clean up #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than hardcode `pkg-config`, allow people to set PKG_CONFIG to point to a version customized for their build.
The standard variable for adding -l flags is LDLIBS, not LIBS. The default Makefile rules (which this code already relies on) will use that when linking. This also fixes a problem where we do not want to list -l flags in the dependency of make targets. When you do that, make will do a file search in /lib and /usr/lib (hardcoded) and expand the path to those absolute files. This breaks when you try to cross- compile miniupnpd for other platforms.
The standard variable for preprocessor flags (e.g. -I and -D) is CPPFLAGS. The default Makefile rules already use this variable when compiling code, so we only need to convert the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.