Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When should a JsonWebKey be considered equal to another? #95

Open
Erik1000 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #96
Open

When should a JsonWebKey be considered equal to another? #95

Erik1000 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #96

Comments

@Erik1000
Copy link
Member

Erik1000 commented Apr 4, 2024 •
edited
Loading

Should all fields be the same, only some, none?
Should it depend on the serialized form being equal?
Erik1000 added a commit that referenced this issue Apr 4, 2024
@Erik1000
fix: remove PartialEq implementation from JsonWebKey
f835fe4 
fixes #95
@Erik1000
Copy link
Member Author

Erik1000 commented Apr 4, 2024

JsonWebKey should not implement PartialEq.

@Erik1000 Erik1000 linked a pull request Apr 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove PartialEq implementation from JsonWebKey minkan-chat/jose
1 participant
@Erik1000