Silence deprecations by default #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the Symfony convention to make our deprecation warning less invasive (PHPUnit and Behat are both triggering exceptions on deprecation errors by default, thus breaking the BC layers). Such deprecations warnings can be logged when using the Symfony error handler or the Symfony PHPUnit bridge (or other tools implementing the same convention).
| @@ -19,6 +19,10 @@ | |||
| "symfony/css-selector": "~2.0" | |||
| }, | |||
|
|
|||
| "require-dev": { | |||
| "symfony/phpunit-bridge": "~2.7" | |||
There was a problem hiding this comment.
I've read http://symfony.com/blog/new-in-symfony-2-7-phpunit-bridge and now I get the clear picture.
There was a problem hiding this comment.
it make test fail if you call a deprecated code path in a non-legacy test
There was a problem hiding this comment.
note that we should also add this dev dependency in our drivers, to make their own test fail when they use deprecated APIs (be it in Mink APIs or in Symfony ones btw). We don't want them to use deprecated APIs.
This was referenced Aug 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the Symfony convention to make our deprecation warning less invasive (PHPUnit and Behat are both triggering exceptions on deprecation errors by default, thus breaking the BC layers).
Such deprecations warnings can be logged when using the Symfony error handler or the Symfony PHPUnit bridge (or other tools implementing the same convention).
There is no such tool for Behat yet, but this is on my TODO list.