Fix the validation of invalid values in tests

minkphp · Nov 29, 2023 · 042979b · 042979b
1 parent 796b01f
commit 042979b
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/BrowserKitDriver.php b/src/BrowserKitDriver.php
@@ -423,8 +423,8 @@ public function setValue(string $xpath, $value)
             return;
         }
 
-        if (\is_array($value) || \is_bool($value)) {
-            throw new DriverException('Textual and file form fields don\'t support array or boolean values');
+        if (\is_array($value) || \is_bool($value) || $value === null) {
+            throw new DriverException('Textual and file form fields don\'t support array, boolean or null values.');
         }
 
         $field->setValue($value);
@@ -592,6 +592,12 @@ protected function prepareUrl(string $url)
     protected function getFormField(string $xpath)
     {
         $fieldNode = $this->getCrawlerNode($this->getFilteredCrawler($xpath));
+        $fieldType = $fieldNode->getAttribute('type');
+
+        if (\in_array($fieldType, ['button', 'submit', 'image'], true)) {
+            throw new DriverException(sprintf('Cannot access a form field of type "%s".', $fieldType));
+        }
+
         $fieldName = str_replace('[]', '', $fieldNode->getAttribute('name'));
 
         $formNode = $this->getFormNode($fieldNode);