Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 5, php 7.4, php 8.0 and Xdebug 3.0 support #151

Closed
wants to merge 36 commits into from
Closed

Symfony 5, php 7.4, php 8.0 and Xdebug 3.0 support #151

wants to merge 36 commits into from

Conversation

Daniel-Marynicz
Copy link

No description provided.

@Daniel-Marynicz Daniel-Marynicz marked this pull request as ready for review April 26, 2020 22:42
@Daniel-Marynicz Daniel-Marynicz mentioned this pull request Apr 27, 2020
Closed
@catch56
Copy link

catch56 commented Jul 28, 2020 •
edited

This should probably be reconciled with #142 which is trying to do the same thing.

@geoffrey-brier
Copy link

Hello 👋
I think it could be great to have this MR merged and a new version tagged, any plan to do so ?
Willing to give a hand if it needs to

vincentchalamon
vincentchalamon reviewed Nov 5, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@Daniel-Marynicz Daniel-Marynicz changed the title Symfony 5 and php 7.4 support Symfony 5, php 7.4, php 8.0 and Xdebug 3.0 support Nov 5, 2020
vincentchalamon
vincentchalamon approved these changes Nov 5, 2020
View reviewed changes
Copy link

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once CI green

Thanks @Daniel-Marynicz !

@Daniel-Marynicz
Copy link
Author

Daniel-Marynicz commented Nov 5, 2020 •
edited

👍 once CI green

Thanks @Daniel-Marynicz !

371.10 failed
but this have in logs "Done. Your build exited with 0." https://travis-ci.org/github/minkphp/MinkBrowserKitDriver/jobs/741646049

stof
stof reviewed Nov 5, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@longwave
Copy link
Contributor

longwave commented Dec 7, 2020

Should SYMFONY_VERSION='^4' be added to the TravisCI matrix?

aik099
aik099 requested changes Dec 10, 2020
View reviewed changes
tests/Custom/ErrorHandlingTest.php Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@aik099
Copy link
Member

aik099 commented Dec 10, 2020

Should SYMFONY_VERSION='^4' be added to the TravisCI matrix?

@longwave , looks valid. I've added that in my review of this PR. Thank you.

kbond added a commit to zenstruck/browser that referenced this pull request Dec 10, 2020
@kbond
temporarily include BrowserKitDriver from https://github.com/minkphp/…
5365f48 
…MinkBrowserKitDriver

until minkphp/MinkBrowserKitDriver#151 is merged and tagged
@vincentchalamon
Copy link

Once this PR merged, is there any reason to keep https://github.com/FriendsOfBehat/MinkBrowserKitDriver @pamil?

@lasdou
Copy link

lasdou commented Mar 25, 2021

UP !
Is there anyone who can do something to have this PR approved and merged ? Please 🙏.
Symfony is out for one year and a half and we still are not able to use this package with it... Thank you very much for your work.

@wouter-toppy
Copy link

Any update on this one?

@stof
Copy link
Member

stof commented Dec 11, 2021

Closing in favor of #161 and #162 (and older PRs about the CI setup)

@stof stof closed this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertfausk robertfausk robertfausk left review comments

@weaverryan weaverryan weaverryan approved these changes

@kbond kbond kbond approved these changes

@vincentchalamon vincentchalamon vincentchalamon approved these changes

@stof stof Awaiting requested review from stof

@aik099 aik099 Awaiting requested review from aik099

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet