Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for method parameters #171

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

stof
Copy link
Member

@stof stof commented Jun 15, 2023

Now that the Mink DriverInterface has parameter types (thanks to minkphp/Mink#856), we can add them in the child class.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #171 (44110c8) into master (55d0474) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     98.00%   98.00%           
- Complexity      125      126    +1     
=========================================
  Files             1        1           
  Lines           301      301           
=========================================
  Hits            295      295           
  Misses            6        6           
Impacted Files Coverage Δ
src/BrowserKitDriver.php 98.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stof stof merged commit 4459adc into minkphp:master Jun 15, 2023
13 checks passed
@stof stof deleted the add_parameter_types branch June 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant