New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to fb webdriver #263
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d5f73f2
Switch to FB webdriver
uuf6429 502cfdb
Various implementations
uuf6429 0e6c204
Increased minimum PHP version to 5.5
uuf6429 dfb3258
Added phpunit dev dep and stop on failure
uuf6429 3f1a406
Fix attempt
uuf6429 496eec3
Remove webdriver setter (BC break)
uuf6429 0587205
Fixed file upload impl. & code style
uuf6429 bd9486a
Removed config added by mistake
uuf6429 f8efc7a
Use composer phpunit in travis
uuf6429 d86efd5
Stop on failure
uuf6429 f100c95
CR and CS fixes
uuf6429 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
return PhpCsFixer\Config::create() | ||
->setRules(array( | ||
'@PSR2' => true, | ||
'array_syntax' => array('syntax' => 'long'), | ||
'concat_with_space' => false, | ||
'phpdoc_align' => true, | ||
'single_quote' => true, | ||
'binary_operator_spaces' => ['align_double_arrow' => true], | ||
)) | ||
->setFinder( | ||
PhpCsFixer\Finder::create() | ||
->in(__DIR__.'/src') | ||
) | ||
; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ cache: | |
directories: | ||
- $HOME/.composer/cache/files | ||
|
||
php: [5.3, 5.4, 5.5, 5.6, 7.0, 7.1, hhvm] | ||
php: [5.5, 5.6, 7.0, 7.1, hhvm] | ||
|
||
env: | ||
- WEBDRIVER=selenium | ||
|
@@ -35,7 +35,7 @@ before_script: | |
# Start a webserver for web fixtures. Force using PHP 5.6 to be able to run it on PHP 5.3 and HHVM jobs too | ||
- MINK_PHP_BIN=~/.phpenv/versions/5.6/bin/php vendor/bin/mink-test-server > /dev/null 2>&1 & | ||
|
||
script: phpunit -v --coverage-clover=coverage.clover | ||
script: phpunit -v --coverage-clover=coverage.clover --stop-on-failure | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert. See #262 (comment). |
||
|
||
after_script: | ||
- wget https://scrutinizer-ci.com/ocular.phar | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,9 @@ | |
], | ||
|
||
"require": { | ||
"php": ">=5.3.1", | ||
"behat/mink": "~1.7@dev", | ||
"instaclick/php-webdriver": "~1.1" | ||
"php": ">=5.5", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert. See #262 (comment). |
||
"behat/mink": "~1.7@dev", | ||
"facebook/webdriver": "~1.3" | ||
}, | ||
|
||
"require-dev": { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert. See #262 (comment).