Allow specify frame index in the "switchToIFrame" driver method #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=========================================
Coverage 90.19% 90.19%
+ Complexity 168 167 -1
=========================================
Files 1 1
Lines 469 469
=========================================
Hits 423 423
Misses 46 46 ☔ View full report in Codecov by Sentry. |
aik099
commented
Feb 18, 2024
| @@ -428,7 +428,7 @@ public function switchToWindow(?string $name = null) | |||
| $this->getWebDriverSession()->focusWindow($name ?: ''); | |||
| } | |||
|
|
|||
| public function switchToIFrame(?string $name = null) | |||
| public function switchToIFrame($name = null) | |||
There was a problem hiding this comment.
Rename to $nameOrIndex in this place?
|
Closing as per minkphp/Mink#866 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See minkphp/Mink#866 (PR 3 of 4)
If the #382 happens to be merged before this PR, then we need to:
masterbranch;if ($name) {line in the\Behat\Mink\Driver\Selenium2Driver::switchToIFramemethod with theif ($name && !is_int($name)) {line.