Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getting the value of a radio group when several forms use the name #105

Merged
merged 1 commit into from Aug 30, 2014

Conversation

stof
Copy link
Member

@stof stof commented Aug 30, 2014

getValue was broken in 2 cases for radio buttons:

  • radio inputs without a name when the node passed to the method is checked
  • multiple input groups with the same name in different forms on the same page

Ref #98

@stof stof mentioned this pull request Aug 30, 2014
@stof
Copy link
Member Author

stof commented Aug 30, 2014

note that this does not fix any test failure yet, because the selection of radio buttons is currently broken (and tests rely on it to manipulate radio groups). See #103 for the work on fixing this part.

@aik099
Copy link
Member

aik099 commented Aug 30, 2014

multiple input groups with the same name in different forms on the same page

Let me rephrase a bit (after looking at code): radios with same name in different forms were considered to be in one group.

@aik099
Copy link
Member

aik099 commented Aug 30, 2014

radio inputs without a name when the node passed to the method is checked

I wonder who will have a form with a single radio button on it, that can be unchecked once pressed 😄

@aik099
Copy link
Member

aik099 commented Aug 30, 2014

OK, can be merged.

stof added a commit that referenced this pull request Aug 30, 2014
Fixed getting the value of a radio group when several forms use the name
@stof stof merged commit f026e6b into minkphp:master Aug 30, 2014
@stof stof deleted the get_radio_value branch August 30, 2014 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants