Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to configure the node modules path in tests #110

Merged
merged 1 commit into from Sep 26, 2014

Conversation

stof
Copy link
Member

@stof stof commented Sep 26, 2014

This allows to run the testsuite when the node_modules cannot be auto-detected (it looks like the globally installed packages using the Ubuntu setup are not in a path looked by require by default, and the current folder is not a parent of the temp folder where the server script gets created, meaning that both the global and local installs are not working without some config on my Ubuntu setup)

@aik099
Copy link
Member

aik099 commented Sep 26, 2014

The locally installed Node modules won't work for sure knowing that we create actual Zombie server file in temp folder and that's where it looks for them 😉

Good to merge.

stof added a commit that referenced this pull request Sep 26, 2014
Added the possibility to configure the node modules path in tests
@stof stof merged commit 7b9032a into minkphp:master Sep 26, 2014
@stof stof deleted the configure_node_modules branch September 26, 2014 07:12
@nonlux
Copy link

nonlux commented Nov 16, 2014

Locally installed zombie is working, if add it in node_modules_path.
But it work only with absolute path.
Maybe add support for relatives path?

@aik099
Copy link
Member

aik099 commented Nov 16, 2014

Relative to what folder exactly? I guess path is absolute because relative path would be calculated from driver location which is /vendor/behat/.....

@nonlux
Copy link

nonlux commented Nov 16, 2014

I think relative path from path of cli execution.
We can't inject it. But we can get it in getpwd().
It may be hardcode.
But the library will not require global installation for zombie.js

@nonlux
Copy link

nonlux commented Nov 16, 2014

Oh! Sorry I am not about test suite, I am about Zombie driver. Create new issue ?

@aik099
Copy link
Member

aik099 commented Nov 16, 2014

Just send PR right away, no need to create issue.

@nonlux
Copy link

nonlux commented Nov 16, 2014

Ok )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants